[FFmpeg-devel] [PATCH 2/2] avcodec/libfdk-aacenc: change MODE_7_1_FRONT_CENTER to map to AV_CH_LAYOUT_7POINT1_WIDE_BACK

[Michael Niedermayer]

On Mon, Jan 27, 2014 at 10:07:41PM +0100, Jean First wrote:
> On Sun Jan 26 2014 14:49:33 GMT+0100 (CET), Michael Niedermayer wrote:
> >This was suggested by Rodeo on IRC
> ><Rodeo> for consistency with the rest, MODE_7_1_FRONT_CENTER would be AV_CH_LAYOUT_7POINT1_WIDE_BACK (since LS+RS is mapped to back channels in other modes)
> >
> >Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> >---
> >  libavcodec/libfdk-aacenc.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/libavcodec/libfdk-aacenc.c b/libavcodec/libfdk-aacenc.c
> >index 4a1cc10..2d91e58 100644
> >--- a/libavcodec/libfdk-aacenc.c
> >+++ b/libavcodec/libfdk-aacenc.c
> >@@ -394,7 +394,7 @@ static const uint64_t aac_channel_layout[] = {
> >      AV_CH_LAYOUT_4POINT0,
> >      AV_CH_LAYOUT_5POINT0_BACK,
> >      AV_CH_LAYOUT_5POINT1_BACK,
> >-    AV_CH_LAYOUT_7POINT1_WIDE,
> >+    AV_CH_LAYOUT_7POINT1_WIDE_BACK,
> >      AV_CH_LAYOUT_7POINT1,
> >      0,
> >  };
> 
> This also looks correct,

applied


> but if I understand the comment mentioned
> in  e10fccf6 correctly MODE_1_2_2_2_1 ( channel config 7 ) should be
> used as default mode.

i certainly dont know the fine details of which of these should be
used but iam happy to apply a patch that changes this

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140127/29e3d242/attachment.asc>