[FFmpeg-devel] [Patch] New filter -- dejudder

Andrey Utkin andrey.krieger.utkin at gmail.com
Thu Jan 30 20:24:24 CET 2014

--- a/Changelog
+++ b/Changelog
@@ -22,7 +22,7 @@ version <next>
 - XYZ12 rawvideo support in NUT
 - Exif metadata support in WebP decoder
 - OpenGL device
+- dejudder filter

nit: have eaten empty line

--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -3215,6 +3215,24 @@ Set whether or not chroma is considered in the
metric calculations. Default is
 @end table

+ at section dejudder
+Remove judder introduced by, for example, @ref{pullup}. If the original source
+was partially telescined content then the output of @code{-vf pullup,dejudder}
+will have a variable frame rate. May change the recorded frame rate of the
+container. Aside from that change, this filter will not effect constant frame
+rate video.

"Remove judder introduced by, for example, @ref{pullup}." - IMHO
better would be "Remove judder. Judder can be introduced, for
instance, by @ref{pullup} filter".
"telescined" - is it right spelling?
" will not effect" - better "will not affect"

+    outlink->time_base = av_mul_q(inlink->time_base,av_make_q( 1 , 2
* (dj->cycle) ));
+    outlink->frame_rate = av_mul_q(inlink->frame_rate,av_make_q( 2 *
(dj->cycle) , 1 ));

In FFmpeg we don't add spacing near brackets at inner side. You have
that also below.
Also we don't put space before comma.

+    if ( dj->start_count ){
+        (dj->start_count)--;

Add space before curly brace (also below).
Brackets before decrement are unneeded.

+    for (i=0; i < dj->cycle + 2; i++)

Spacing: i = 0...

Otherwise seems nice if it works (i haven't checked logics).

Andrey Utkin

More information about the ffmpeg-devel mailing list