[FFmpeg-devel] [Patch] New filter -- dejudder

Nicholas Robbins nickrobbins at yahoo.com
Thu Jan 30 21:17:57 CET 2014

On Thursday, January 30, 2014 2:24 PM, Andrey Utkin <andrey.krieger.utkin at gmail.com> wrote:

>nit: have eaten empty line


>"Remove judder introduced by, for example, @ref{pullup}." - IMHO
>better would be "Remove judder. Judder can be introduced, for
>instance, by @ref{pullup} filter".
>"telescined" - is it right spelling?
>" will not effect" - better "will not affect"

That is clearer. Corrected.

>In FFmpeg we don't add spacing near brackets at inner side. You have
>that also below.
>Also we don't put space before comma.

Fixed and fixed.

>Add space before curly brace (also below).
>Brackets before decrement are unneeded.

Fixed and fixed.

>+    for (i=0; i < dj->cycle + 2; i++)
>Spacing: i = 0...


>Otherwise seems nice if it works (i haven't checked logics).
>Andrey Utkin
Thanks for the crash course on formatting. New patch attached.

Nicholas Robbins
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Adding-dejudder-filter-to-remove-judder-produced-by-.patch
Type: text/x-patch
Size: 8342 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140130/0ac6e3da/attachment.bin>

More information about the ffmpeg-devel mailing list