[FFmpeg-devel] FFmpeg OPW

Timothy Gu timothygu99 at gmail.com
Fri Jul 4 06:04:25 CEST 2014


On Thu, Jul 3, 2014 at 8:15 PM, Reynaldo H. Verdejo Pinochet
<r.verdejo at sisa.samsung.com> wrote:
> Hi Timothy.
>
>
> On 07/03/2014 08:34 PM, Timothy Gu wrote:
>>
>> On Thu, Jul 3, 2014 at 3:11 PM, Reynaldo H. Verdejo Pinochet wrote:
>>>
>>> Patch for web/news attached. OK to commit?
>>
>>
>> Please do a 80-col wrap. Some remarks:
>
>
> Wouldn't generally wrap HTML text inside </p> to avoid littering
> it with trailing white space but looking at rest of the entries
> it seems to be preferred indeed. Done.
>
>
>>
>>> +support at least one internship (6K USD) so if you were holding on
>>
>>
>> USD). So if you are holding on to
>
>
> Meant to use "were" and don't like the "to" in "TO your donation TO
> FFmpeg", guess the meaning its clear and still gramaticaly correct?
>
>
>>
>>> +your donation to FFmpeg, this is a great chance for you to come
>>> +forward, get in touch and help both the project and a great initiative
>>> +all at once!
>>
>>
>> This sentence is kinda long. Consider dropping "get in touch" and/or
>> "all at once" and/or breaking up the sentence.
>>
>
> Dropped the "all at once" but I'm not 100% happy with the sentence.
> That was the bit I wanted to stress. Anyway, done.
>
> The 'long' enumerative I kept. That was an style/tone decision.

Patch LGTM.

Timothy


More information about the ffmpeg-devel mailing list