[FFmpeg-devel] [PATCH] use JPEG color range for RoQ

Michael Niedermayer michaelni at gmx.at
Sun Jul 6 23:41:17 CEST 2014


On Sun, Jul 06, 2014 at 04:17:16PM -0400, Eric Lasota wrote:
> The first-party codec uses JPEG YUV, see values in ROQ_GenYUVTables:
> https://github.com/id-Software/Quake-III-Arena/blob/master/code/client/cl_cin.c
> 
> Test with idlogo.roq:
> Reference implementation: http://i.imgur.com/QeywyIr.png (enlarged to work
> around a rendering bug)
> ffmpeg without patch: http://i.imgur.com/Q7ZHBPd.png
> ffmpeg with patch: http://i.imgur.com/ZJE01uy.png

>  roqvideodec.c |    2 +-
>  roqvideoenc.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> a4f768fff83e72ea7f356c2b12b0ed6170d043bc  0001-use-JPEG-color-range-for-RoQ.patch
> From ca0e542adf924b42a8502e313fa911576924978f Mon Sep 17 00:00:00 2001
> From: ejlasota <ejlasota at gmail.com>
> Date: Sun, 6 Jul 2014 15:42:43 -0400
> Subject: [PATCH] use JPEG color range for RoQ

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140706/d09f0a6b/attachment.asc>


More information about the ffmpeg-devel mailing list