[FFmpeg-devel] [PATCH] AVFormat: LRC demuxer and muxer
derek.buitenhuis at gmail.com
Wed Jul 9 16:09:06 CEST 2014
On 7/9/2014 2:42 PM, Carl Eugen Hoyos wrote:
>> + if(!memcmp(p->buf + offset, "[ti:", 4) ||
>> + !memcmp(p->buf + offset, "[al:", 4) ||
>> + !memcmp(p->buf + offset, "[ar:", 4))
>> + return AVPROBE_SCORE_MAX;
> MAX score is not ok for 32bit, use MAX/2 (or less).
Too elaborate on this, since Carl worded it very poorly (it
sounds like he is talking about 32bit vs 64bit archs):
libavformat apparently has 'strong' and 'weak' probes, and you
are only allowed to use MAX/2 for 'weak' probes. Checking only
4 bytes (32 bits) is considered weak, and thus limited to MAX/2.
I hope that makes it a tad clearer.
More information about the ffmpeg-devel