[FFmpeg-devel] [PATCH] lavf: add samba protocol via libsmbclient

Derek Buitenhuis derek.buitenhuis at gmail.com
Sun Jul 13 19:54:16 CEST 2014


On 7/13/2014 6:38 PM, Lukasz Marek wrote:
> I am not sure about that. I agree it is a bit strange libavformat has 
> both (de)muxers and protocols. I would expect it to be separated, but 
> overall I don't don't agree it is bad ffmpeg has them at all.

Such a library exists. It's called libcurl.

> - ffmpeg contains not just libraries, but also tools. (ffmpeg is 
> probably the most remarkable). You would need to move these protocols 
> there, or have no such functionality at all. Reading some forums etc 
> people seems to use it.

Using the FFmpeg CLI doesn't really fit with "can't mount anything", in
my books, but YMMV.

> - implementing protocols (like ftp you mentioned) inside the project 
> benefits both developers who use ffmpeg and the end user. developers 
> have less work and they all possibly contribute to the project when bugs 
> are found. In case all projects implement over and over the same 
> functionality, there is much bigger chance more products is bugged.

Personally I've always thought it would be preferable to integrate something
like libcurl instead of writing our own implementations of every little
protocol, and the terrible mess that is our TLS support.

> - let's say there is a company X. Company X needs to release a product 
> in 3 months with tons of functional requirements demanded by the client. 
> Do you think they would pick minimalistic library when there is other 
> that offers more? This is not just theoretical question. I saw this 
> happened with ffmpeg in the company I work.

I'm sure people who have to throw together some terrible thing in 3 months
with a hard time limit always design the best software...

I find it hard to believe they can master using something as complex as the
libav* libraries, but not something like libcurl or libsmb, which comparatively,
is much simpler.

Anyway, as I said before, I am not blocking this patch -- it's just my 2 cents.

- Derek


More information about the ffmpeg-devel mailing list