[FFmpeg-devel] [PATCH] lavfi: check refcount before merging.

Michael Niedermayer michaelni at gmx.at
Tue Jul 15 21:08:30 CEST 2014


On Tue, Jul 15, 2014 at 07:30:35PM +0200, Nicolas George wrote:
> When merging the formats around the automatically inserted
> convert filters, the refcount of the format lists can not be 0.
> Coverity does not detect it, and suspects a memory leak,
> because if refcount is 0 the newly allocated lists are not
> stored anywhere. That gives CIDs 1224282, 1224283 and 1224284.
> Lists with refcount 0 are used in can_merge_formats(), so the
> asserts can not be moved inside the merge functions.
> 
> Signed-off-by: Nicolas George <george at nsup.org>

LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140715/74c5ee83/attachment.asc>


More information about the ffmpeg-devel mailing list