[FFmpeg-devel] [PATCH] lavfi/drawtext: add alias "expr_int_format" to expansion function "eif"

Andrey Utkin andrey.krieger.utkin at gmail.com
Fri Jul 18 00:40:09 CEST 2014

2014-07-18 1:05 GMT+03:00 Nicolas George <george at nsup.org>:
> Le decadi 30 messidor, an CCXXII, Andrey Utkin a écrit :
>> ---
>>  doc/filters.texi          | 2 +-
>>  libavfilter/vf_drawtext.c | 3 ++-
>>  2 files changed, 3 insertions(+), 2 deletions(-)
> IMHO, since the function was added extremely recently, it is ok to just
> change the name.

Not principal on this, i just think it is natural, as long as we have
"e" alias for "expr". I think "eif" is good to have, too. Aliases cost
nothing there.

> May I suggest: format_expr()? That way, if somebody extends it to accept
> more versatile format strings, including floats, the name still works.

Floats are output by "expr".
And i'm afraid that making the formatting function more generic would
add a lot of complexity (including safety checks). Actually now i
cannot imagine how would it look like, and what are the use cases.

Andrey Utkin

More information about the ffmpeg-devel mailing list