[FFmpeg-devel] rectification filter
danieloberhoff at gmail.com
Tue Jul 29 11:58:55 CEST 2014
On Jul 29, 2014, at 11:56 AM, James Darnley <james.darnley at gmail.com> wrote:
> On 2014-07-29 07:41, Daniel Oberhoff wrote:
>> First off thanks for taking the time to review.
>> Am 29.07.2014 um 01:16 schrieb Carl Eugen Hoyos <cehoyos at ag.or.at>:
>>> Daniel Oberhoff <danieloberhoff <at> gmail.com> writes:
>>>> + * This program is free software; you can redistribute it and/or modify
>>>> + * it under the terms of the GNU General Public License
>>> Your patch is missing a configure hunk that
>>> makes sure that the filter is only compiled
>>> if --enable-gpl was specified.
>>> Search for *filter_deps="gpl" for an example.
>> That notice is left over from the original rectification filter from which I started, but since I effectively rewrote every single line and ended up reusing only the algorithm I am going to re-license the code under lgpl.
> I don't think that's how it works. Did you study the algorithm from an
> abstract document describing the process or the original filter code?
Ok, I understand, sorry, this is my first time contributing like this. I will get in contact with the author about the license and I will mention him in the header.
More information about the ffmpeg-devel