[FFmpeg-devel] [PATCH 1/3] dict.c: Free non-strduped av_dict_set arguments on error.

Michael Niedermayer michaelni at gmx.at
Tue Jul 29 22:13:39 CEST 2014


On Tue, Jul 29, 2014 at 09:26:48PM +0200, Reimar Döffinger wrote:
> Unfortunately this was not explicitly documented and thus
> might be very risky.
> But basically all uses I saw in FFmpeg had a memleak in these
> cases.
> 
> Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> ---
>  libavutil/dict.c | 9 +++++++--
>  libavutil/dict.h | 2 ++
>  2 files changed, 9 insertions(+), 2 deletions(-)

doesnt apply

Applying: dict.c: Free non-strduped av_dict_set arguments on error.
fatal: sha1 information is lacking or useless (libavutil/dict.c).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 dict.c: Free non-strduped av_dict_set arguments on error.


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140729/fbc08b85/attachment.asc>


More information about the ffmpeg-devel mailing list