[FFmpeg-devel] [PATCH 2/7] avformat/hlsenc: make the code easier to read

Michael Niedermayer michaelni at gmx.at
Thu Jul 31 01:04:59 CEST 2014

On Wed, Jul 30, 2014 at 10:25:45AM +0200, Nicolas Martyanoff wrote:
> On 2014-07-29 16:15, Michael Niedermayer wrote:
> > On Fri, Jul 18, 2014 at 10:57:42AM +0200, Nicolas Martyanoff wrote:
> > > Before adding new features, I read the code and cleaned it. The main issue was
> > > abstruse identifier names.
> > > 
> > > The behaviour of the muxer is *not* modified, by this patch, this is only
> > > cosmetic. If this is not the case, it is a mistake.
> > > ---
> > >  libavformat/hlsenc.c | 360 ++++++++++++++++++++++++++++++---------------------
> > >  1 file changed, 213 insertions(+), 147 deletions(-)
> > 
> > This should be ok if you add yourself to MAINTAINERs for hlsenc,
> > that is you volunteer to maintain hlsenc.
> > 
> > Otherwise i think its better if we avoid large cosmetic changes so
> > merges from any forks stay easy and non conflicting
> Hi Michael,
> I would be happy to help if bugs are found or if new features have to be
> added, but I am not sure I have the time to commit to officially maintaining
> the module.
> Would that be satisfying ?

ok, ive split and applied some parts of the patch.
Iam happy to apply the rest too, if you want and split it cleanly

But we then might need help in integrating changes that are based
on the pre-cleanup version. (I dont know if anyone / any fork will
ignore the cleanup and work on top of the old code or not).
Alternatively we of course could in that case revert the cleanup
if it causes conflicts ...

also, "I would be happy to help if bugs are found or if new features
have to be added" <--- thats pretty much what maintainership is about
and also reviewing patches, but there havnt been that many patches
for hlsenc IIRC
So maybe you want to add yourself to MAINTAINERs anyway ?
You can always post a patch to remove yourself again if you loose


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140731/d25fe5c0/attachment.asc>

More information about the ffmpeg-devel mailing list