[FFmpeg-devel] [PATCH 5/5] [FATESERVER] index: improve sorting
Timothy Gu
timothygu99 at gmail.com
Sun Jun 1 01:45:50 CEST 2014
1. Using revision as the primary sorting factor, and date as secondary is the
most logical. Removing comment because nobody would ever want to sort
alphabetically by comment. I kept slot though to ensure reproducible
"bottom-line" sorting.
2. Using $status instead of $npass for test result sorting because the latter
doesn't work well with build-only test instances.
3. Make sorting by revision descending by default to for consistency with
date.
Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
---
index.cgi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/index.cgi b/index.cgi
index 2246920..163e0a7 100755
--- a/index.cgi
+++ b/index.cgi
@@ -79,7 +79,7 @@ $allpass = 100 * $allpass / @reps;
$allfail = 100 * $allfail / @reps;
my $warn = 100 - $allpass - $allfail;
-my @sort = ('subarch', 'os', 'cc', 'comment', 'slot');
+my @sort = ('descrev', 'descdate', 'subarch', 'os', 'cc', 'slot');
my $sort = param('sort');
my $sdir = 1; # default to ascending sorting
defined $sort and unshift @sort, $sort eq 'arch'? 'subarch': $sort;
@@ -214,13 +214,13 @@ end 'td';
end 'tr';
start 'tr';
start 'th'; lsort 'Time', 'descdate'; end 'th';
-start 'th'; lsort 'Rev', 'rev'; end 'th';
+start 'th'; lsort 'Rev', 'descrev'; end 'th';
start 'th'; lsort 'Arch', 'arch'; end 'th';
start 'th'; lsort 'OS', 'os'; end 'th';
start 'th'; lsort 'Compiler', 'cc'; end 'th';
start 'th'; lsort 'Comment', 'comment'; end 'th';
start 'th', colspan => 2; lsort 'Warnings', 'nwarn'; end 'th';
-start 'th', colspan => 2; lsort 'Tests', 'npass'; end 'th';
+start 'th', colspan => 2; lsort 'Tests', 'descstatus'; end 'th';
end 'tr';
end 'thead';
start 'tbody';
--
1.9.1
More information about the ffmpeg-devel
mailing list