[FFmpeg-devel] [WIP] [PATCH 4/4] x86: dsputilenc: convert hf_noise*_mmx to yasm

Christophe Gisquet christophe.gisquet at gmail.com
Mon Jun 2 08:31:54 CEST 2014


Hi,

2014-06-02 0:44 GMT+02:00 Timothy Gu <timothygu99 at gmail.com>:
> On Thu, May 29, 2014 at 8:56 PM, Timothy Gu <timothygu99 at gmail.com> wrote:
>> Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
>> ---
>> hf_noise16 segfaults with make fate-vsynth1-mpeg4-nsse, but I don't know
>> how to fix it. Also, did I get the `call` right?
>
> Ping. Anybody have an idea on this?

Like Michael said, avoid doing the call yourself at all cost. From the
looks of it, you can just write in C:
score2 = ff_hf_noise16_mmx(pix1, line_size, h) +
ff_hf_noise8_mmx(pix1+8, line_size, h)
            - ff_hf_noise16_mmx(pix2, line_size, h) -
ff_hf_noise8_mmx(pix2+8, line_size, h);

Or something.

-- 
Christophe


More information about the ffmpeg-devel mailing list