[FFmpeg-devel] [PATCH]Allow >2G for skip_initial_bytes

[Michael Niedermayer]

On Thu, Jun 05, 2014 at 11:13:37PM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch allows larger values for -skip_initial_bytes.
> 
> Please comment, Carl Eugen

>  avformat.h      |   12 +++++++++---
>  options_table.h |    2 +-
>  utils.c         |    1 +
>  3 files changed, 11 insertions(+), 4 deletions(-)
> 1a5d9b5e4e2960a8ff444ebcb3efd57e4063fc48  patchinitialbytes.diff
> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> index 01c3b75..f3b6614 100644
> --- a/libavformat/avformat.h
> +++ b/libavformat/avformat.h
> @@ -1494,10 +1494,9 @@ typedef struct AVFormatContext {
>      enum AVDurationEstimationMethod duration_estimation_method;
>  
>      /**
> -     * Skip initial bytes when opening stream
> -     * - encoding: unused
> -     * - decoding: Set by user via AVOptions (NO direct access)
> +     * @deprecated deprecated in favor of skip_initial_bytes2()
>       */
> +    attribute_deprecated
>      unsigned int skip_initial_bytes;

i think you can remove this field
that is if all fields afterwards are internal / "NO direct access"

patch LGTM

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140605/3d012c71/attachment.asc>