[FFmpeg-devel] [PATCH] Recognize MJPEG at probing

[Andrey Utkin]

2014-06-10 1:25 GMT+03:00 Michael Niedermayer <michaelni at gmx.at>:
> On Tue, Jun 10, 2014 at 12:44:54AM +0300, Andrey Utkin wrote:
>> 2014-06-09 18:57 GMT+03:00 Michael Niedermayer <michaelni at gmx.at>:
>> > fixed differently
>>
>> will test tomorrow
>>
>> > also if theres a bug in http which seems like there is, this should
>> > be fixed as well
>>
>> I don't see plain HTTP driver bug here. Why do you think so?
>
> i extracted the data from the pcap file with wireshark and tried the
> patch and it didnt detect it. It seemed wiresharks http code
> removed the line as part of teh http headers
> which hints towards either its or ffmpegs http code having a bug

Maybe you have missed the point where the data which gets to AVPacket
and AVProbeData starts? There's tricky thing that Content-Type:
image/jpeg is actually inside of data stream and that is right.
I have tested your commit and it works, although the warning it
produces feels wrong
[mjpeg @ 0x26c6560] Format mjpeg detected only with low score of 25,
misdetection possible!
While i think we have enough info to recognize JPEG stream 100% sure,
as we have explicit Content-Type.

-- 
Andrey Utkin