[FFmpeg-devel] [FATESERVER/PATCH 8/8] index: improve sorting

[Timothy Gu]

1. Using status and number of failed tests as the primary sorting factor,
   and revision and date as secondary is the most logical. Removing comment
   because nobody would ever want to sort alphabetically by comment. I kept
   slot though to ensure reproducible "bottom-line" sorting.

   The rationale is that most people would like to see the newest tests that
   failed, then the older tests that failed, then the other tests. I took
   into account that # of failed as a sorting factor, but using status is
   also needed to filter out build failures.

2. Using both $status and $nfail as sorting factors for results, because
   most people would like to see building failure -> test failure -> all
   green.

3. Make sorting by revision descending by default to for consistency with
   date.

Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
---
The changes try to address Derek's concern, but whether of the two
orders: `new failed -> old failed -> new OK` or
        `new failed -> new OK     -> old failed`
is debatable. Currently, the patch uses the former algorithm.
---
 index.cgi | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/index.cgi b/index.cgi
index 7204591..016568c 100755
--- a/index.cgi
+++ b/index.cgi
@@ -79,7 +79,8 @@ $allpass = 100 * $allpass / @reps;
 $allfail = 100 * $allfail / @reps;
 my $warn = 100 - $allpass - $allfail;
 
-my @sort = ('subarch', 'os', 'cc', 'comment', 'slot');
+my @sort = ('descstatus', 'descnfail', 'descrev', 'descdate', 'subarch', 'os',
+            'cc', 'slot');
 my $sdir = 1; # default to ascending sorting
 defined $sort and unshift @sort, split /\/\//, $sort;
 $sort ||= $sort[0];
@@ -231,13 +232,13 @@ end 'td';
 end 'tr';
 start 'tr';
 start 'th'; lsort 'Time',     'descdate';      end 'th';
-start 'th'; lsort 'Rev',      'rev';           end 'th';
+start 'th'; lsort 'Rev',      'descrev';       end 'th';
 start 'th'; lsort 'Arch',     'arch';          end 'th';
 start 'th'; lsort 'OS',       'os';            end 'th';
 start 'th'; lsort 'Compiler', 'cc';            end 'th';
 start 'th'; lsort 'Comment',  'comment';       end 'th';
 start 'th', colspan => 2; lsort 'Warnings', 'nwarn'; end 'th';
-start 'th', colspan => 2; lsort 'Tests', 'npass'; end 'th';
+start 'th', colspan => 2; lsort 'Tests', 'descstatus//descnfail'; end 'th';
 end 'tr';
 end 'thead';
 start 'tbody';
-- 
1.9.1