[FFmpeg-devel] [PATCH] swr: handle initial negative sample index outside DSP function.

Michael Niedermayer michaelni at gmx.at
Wed Jun 11 13:44:45 CEST 2014


On Tue, Jun 10, 2014 at 09:50:14PM -0400, Ronald S. Bultje wrote:
> The new function in struct Resampler and code therefore in resample()
> are admittedly butt-ugly. I'll probably clean it up but at least it
> works so I figured I'd send it out and see what people think. What I'd
> really like to do is to be able to expose ResampleContext to swresample.c
> if people are OK with that.

exposing it may be ok, but theres not always a ResampleContext
we also support resampling through soxr (which uses a fft based
resampler).
i think the patch will break that due to
invert_initial_buffer_func being NULL

also this seems to give different output with
./ffmpeg -i matrixbench_mpeg2.mpg -af asetnsamples=1,aresample=8000 -t 30 foo.wav
vs.
./ffmpeg -i matrixbench_mpeg2.mpg -af asetnsamples=1024,aresample=8000 -t 30 foo.wav

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140611/124cfbbb/attachment.asc>


More information about the ffmpeg-devel mailing list