[FFmpeg-devel] [Patch]x86/hevc : new idct + ASM

[Pierre Edouard Lepere]

OK, I've added #if HAVE_YASM around the functions.

----- Mail original -----
De: "Michael Niedermayer" <michaelni at gmx.at>
À: "FFmpeg development discussions and patches" <ffmpeg-devel at ffmpeg.org>
Envoyé: Vendredi 13 Juin 2014 00:03:04
Objet: Re: [FFmpeg-devel] [Patch]x86/hevc : new idct + ASM

On Thu, Jun 12, 2014 at 01:56:29PM +0200, Pierre Edouard Lepere wrote:
> Hi,
> 
> I've "started over" using x264's way of doing things. The C is unchanged. there are now mmxext, sse2 and avx functions.
> 
> Thank you for your feedback,
> Pierre-Edouard Lepere

>  hevc_cabac.c       |   17 +++
>  hevcdsp.c          |    5 +
>  hevcdsp.h          |    4 
>  hevcdsp_template.c |  254 +++++++++++++++++++++--------------------------------
>  x86/Makefile       |    3 
>  x86/hevc_idct.asm  |  180 +++++++++++++++++++++++++++++++++++++
>  x86/hevcdsp.h      |   25 +++++
>  x86/hevcdsp_init.c |   67 +++++++++++++
>  8 files changed, 397 insertions(+), 158 deletions(-)
> 057ed2a7907f9ebe60ce080261fd0ae149ea1f7b  0001-added-new-idct-and-first-idct-asm.patch
> From c2c5f9d2882955339f5c3ca8552a45b04e4abbe4 Mon Sep 17 00:00:00 2001
> From: plepere <pierre-edouard.lepere at insa-rennes.fr>
> Date: Mon, 2 Jun 2014 10:51:25 +0200
> Subject: [PATCH] added new idct and first idct asm
> 
> ---
>  libavcodec/hevc_cabac.c       |  17 ++-
>  libavcodec/hevcdsp.c          |   5 +
>  libavcodec/hevcdsp.h          |   4 +-
>  libavcodec/hevcdsp_template.c | 254 +++++++++++++++++-------------------------
>  libavcodec/x86/Makefile       |   3 +-
>  libavcodec/x86/hevc_idct.asm  | 180 ++++++++++++++++++++++++++++++
>  libavcodec/x86/hevcdsp.h      |  25 +++++
>  libavcodec/x86/hevcdsp_init.c |  67 ++++++++++-
>  8 files changed, 397 insertions(+), 158 deletions(-)
>  create mode 100644 libavcodec/x86/hevc_idct.asm

this fails building with
./configure --disable-yasm && make -j12

libavcodec/libavcodec.a(hevcdsp_init.o): In function `ff_hevc_idct32_dc_add_8_sse2':
libavcodec/x86/hevcdsp_init.c:55: undefined reference to `ff_hevc_idct16_dc_add_8_sse2'
libavcodec/x86/hevcdsp_init.c:56: undefined reference to `ff_hevc_idct16_dc_add_8_sse2'
libavcodec/x86/hevcdsp_init.c:57: undefined reference to `ff_hevc_idct16_dc_add_8_sse2'
libavcodec/libavcodec.a(hevcdsp_init.o): In function `ff_hevc_idct16_dc_add_10_sse2':
libavcodec/x86/hevcdsp_init.c:63: undefined reference to `ff_hevc_idct8_dc_add_10_sse2'


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-added-new-idct-and-first-idct-asm.patch
Type: text/x-patch
Size: 31769 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140613/f304e3f2/attachment.bin>