[FFmpeg-devel] [PATCH] libx265: Update bitrate in avcontext in case it was overriden by x265 specific options

[Nicolas Morey-Chaisemartin]

On 06/13/2014 03:44 PM, Derek Buitenhuis wrote:
>
> I'm more thinking, what are the consequences for API users?
>
> https://www.ffmpeg.org/doxygen/trunk/structAVCodecContext.html#ad9214d5af3e98ea7f1d4e94be6a522de
>
> The doxygen says set by user -- are we even allowed to change it?
>
> Perhaps I am over-thinking this.
It doesn't seem to be widely used but to pass the option to the different encoder. It seems to have been there for x264 wrapper for quite some time so it shouldn't be too much of an issue I guess.
>
>> On another subject, is it the wanted behavior to silently ignore x265-params string if av_dict_parse_string fails?
>> x264 wrapper does the same but it's a real hassle to figure out why option keep being ignored !
> I suppose it could print a warning about garbage strings being supplied.
That'd be good !
I made a quick patch (with bad coding style) that shows an errors and return from the init with an error. users tend not to read warning message unless something blows up in their face :)