[FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

[Carl Eugen Hoyos]

Clément Bœsch <u <at> pkh.me> writes:

> > > It's not needlessly since it fixes builds when libx264 is 
> > > built against external libs to the least, without a hack 
> > > of trying to guess what library could be needed. It 
> > > simplifies the creation of static builds.
> > 
> > This sounds as if these were two different issues, 
> > do I misunderstand?
> > 
> 
> You don't misunderstand, I was enumerating a bunch of 
> problems with the current hack.

But the first issue (external libs) only exists 
together with the second (static build), so there 
is only one issue or am I wrong?

> > > And also it simplifies specifying a custom x264 build.
> > 
> > It definitely doesn't simplify things, I honestly wonder 
> > if everybody on this list knows how to use the future 
> > variant, while I consider the current solution very 
> > user-friendly.
> 
> Very user friendly? To specify compiler and linker flags 
> manually?

Yes.
Compared of course to a variable that nobody (except 
you) knows of and that no user will ever find.
(I am still hoping that Timothy proves me wrong.)

> It says to install pkg-config?

This unfortunately isn't the point.
The point is that you still have to tell your 
configure line where to search, and that this 
is much simpler with the current implementation.
And configure --help tells you about it.

> Well, every time I wanted a custom build with special 
> paths or options, I was always ended up reading or 
> hacking the configure with echo to figure out what 
> was going on.

Sorry, I really don't understand that.
In which situation was this ever necessary?

> > My other concern is more personal: I hate to install, 
> > and particularly if it is not necessary.
> > I would expect that this would also hit a few users, 
> > possibly less than the pkg-config issue.
> 
> pkg-config is a 100kB standalone portable C program

I meant I hate to install a custom x264 build.

Carl Eugen