[FFmpeg-devel] [PATCH]Fix compilation on darwin ppc64 if gas-preprocessor is installed

Michael Niedermayer michaelni at gmx.at
Wed Jun 18 20:26:57 CEST 2014


On Wed, Jun 18, 2014 at 03:11:19PM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Compilation currently fails on darwin ppc64 (and darwin ppc with --enable-pic) 
> if gas-preprocessor is installed.
> Attached patch fixes this here, better suggestions welcome.
> 
> Please comment, Carl Eugen

>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 2d74c311a5de071d3d991e812f1700c1a030d197  patchdarwinppc64.diff
> diff --git a/configure b/configure
> index d1eb8da..a1d1771 100755
> --- a/configure
> +++ b/configure
> @@ -4287,7 +4287,7 @@ EOF
>  od -t x1 $TMPO | grep -q '42 *49 *47 *45' && enable bigendian
>  
>  
> -if enabled asm; then
> +if enabled asm && [ $target_os != darwin ] || ! enabled ppc || ! enabled_any ppc64 pic ; then

this looks a bit complex
and it could be true even when asm is disabled this seems odd

also what happens if
this:
        test "${as#*gas-preprocessor.pl}" != "$as" || gas="${gas:=gas-preprocessor.pl} ${as:=$cc}"
is skiped for ppc* or the cases where it fails ?

or am i missing something ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140618/418086dd/attachment.asc>


More information about the ffmpeg-devel mailing list