[FFmpeg-devel] [RFC/PATCH]Allow to use ancient bash to make version.h

Carl Eugen Hoyos cehoyos at ag.or.at
Thu Jun 19 19:42:41 CEST 2014

Clément Bœsch <u <at> pkh.me> writes:

> >  # check for git short hash
> > -if ! test "$revision"; then
> > -    revision=$(cd "$1" && git describe --tags --match N 2> /dev/null)
> > -fi
> > +test "$revision" ||
> > +    revision=`cd "$1" && git describe --tags --match N 2> /dev/null`
> This is a joke, right? :)

Hard to say...

If you consider compilation failure reports 
from users in general a joke:
Of course!

We know that /bin/sh doesn't work on SunOS (or 
whatever it's called), you need to invoke configure 
with a working shell.
But the version.sh script is small and supporting 
ancient shells seems easy and straight-forward to 
me, so except for "Solaris sucks", I currently 
don't see a technical argument against it.
Or does the patch break any existing system? In 
this case, please consider the patch dropped.

> What version of bash is that?

(I don't have access to a Solaris installation 
but I get the exact same error with this shell 
that claims to be the Solaris shell.)

Carl Eugen

More information about the ffmpeg-devel mailing list