[FFmpeg-devel] [PATCH] set/force channelcount in MXF D-10

[tim nicholson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 26/06/14 16:09, Tomas Härdin wrote:
> On Wed, 2014-06-25 at 10:29 +0000, Gaullier Nicolas wrote:
>> +static const AVOption d10_options[] = {
>> +    { "mxf_channelcount", "Force/set channelcount in generic sound essence descriptor",
>> +      offsetof(MXFContext, channel_count), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 8, AV_OPT_FLAG_ENCODING_PARAM},
>> +    { NULL },
>> +};
> 
> Too late to point this out since it's already pushed but: it'd be nicer
> if this option was called "d10_channelcount" to further emphasize that
> this is D-10 specific.
>

I would +1 this, D10 is quite a specific subset of possible aes3
layouts. And files with aes3 streams that do not populate unused and
invalid channels can be readily found in the wild.


> /Tomas
> 


- -- 
Tim.
Key Fingerprint 38CF DB09 3ED0 F607 8B67 6CED 0C0B FC44 8B0B FC83
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTrD1yAAoJEAwL/ESLC/yDxcEH/A8UK9U4riN5FR0kkrOuZm2Y
Frj7omxV64ptvv+MI3shbstNEkJyZHbj/HuQSctTswzCLDTOZ0qUZKbn0IV6Q6WD
OU4OOltMZD34GINjUdNRL5EujMj4+4V6HyMqxRfD+qPPCqdd8vgZMUBBOBEAndRZ
EJjYAe8qPmZfOiNceobTuM4Cuhw/N0zWQ6WeMRAOplgoZidEjl6aED8BwRoZC7U9
YtYewVHC9wOF90l7UTJKNWkl4dRRp1J9F5mj2k7Xu/eDfMOlXR6daekqYpSzo3Ad
eliOcwLHAReeVFbjAso07F8Q88s3QX4/UDn9OvLgJbwm18KOX90jESu6uILd4JY=
=yJvp
-----END PGP SIGNATURE-----