[FFmpeg-devel] [PATCH] set/force channelcount in MXF D-10

[Michael Niedermayer]

On Thu, Jun 26, 2014 at 04:10:45PM +0000, Gaullier Nicolas wrote:
> >De : ffmpeg-devel-bounces at ffmpeg.org [mailto:ffmpeg-devel-bounces at ffmpeg.org] De la part de tim nicholson
> >Envoyé : jeudi 26 juin 2014 17:34
> >On 26/06/14 16:09, Tomas Härdin wrote:
> >> On Wed, 2014-06-25 at 10:29 +0000, Gaullier Nicolas wrote:
> >>> +static const AVOption d10_options[] = {
> >>> +    { "mxf_channelcount", "Force/set channelcount in generic sound essence descriptor",
> >>> +      offsetof(MXFContext, channel_count), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 8, AV_OPT_FLAG_ENCODING_PARAM},
> >>> +    { NULL },
> >>> +};
> >> 
> >> Too late to point this out since it's already pushed but: it'd be 
> >> nicer if this option was called "d10_channelcount" to further 
> >> emphasize that this is D-10 specific.
> >>
> >I would +1 this, D10 is quite a specific subset of possible aes3 layouts. And files with aes3 streams that do not populate unused and invalid channels can be readily found in the wild.
> 
> Agree, here you have

applied

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140627/c0e091c0/attachment.asc>