[FFmpeg-devel] [lavfi][aalib][PATCH] lavfi: add aalib video filter.

Michael Niedermayer michaelni at gmx.at
Sun Jun 29 19:19:30 CEST 2014

On Sun, Jun 29, 2014 at 08:53:57PM +0400, iamtakingiteasy at eientei.org wrote:
> On 2014-06-29 19:20, iamtakingiteasy at eientei.org wrote:
> >This is second iteration of review for vf_aa (ascii-art aalib
> >video filter).
> >
> >See message with subject
> >* [lavfi][aalib][PATCH] lavfi: Generalization of freetype/fontconfig
> >font loading.
> >for dependent patch and the
> >* aalib video filter patch review request
> >discussion.
> This one seems to be very wrong too.
> The one missing thing from main loop in filter_frame() function
> seems to be:
> av_frame_copy_props(outframe, inframe);
> outframe->width  = outlink->w;
> outframe->height = outlink->h;
> Which should bring back the framerate in ffmpeg.

> Yet it is still missing something crucial, which is not noticable
> with ffplay, but making actual ffmpeg constantly increase bitrate.
> I wonder, what could it be? Valgrind doesn't pokes anything
> suspicious, but something is definently leaking. In sense of
> bitrate.

make sure pts and timebase are passed through correctly

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140629/c0b999c0/attachment.asc>

More information about the ffmpeg-devel mailing list