[FFmpeg-devel] [PATCH] ra144enc: fix use of scalarprod_int16

[Michael Niedermayer]

On Wed, Mar 05, 2014 at 03:51:30PM -0300, James Almer wrote:
> On 05/03/14 10:31 AM, Michael Niedermayer wrote:
> > On Wed, Mar 05, 2014 at 01:06:31PM +0100, Christophe Gisquet wrote:
> >> Fix for #3429, which affected MMX/MMXExt machines, introduced by
> >> c3390fd56cf55259ea7665ecea6c8aeddf56e2fc.
> >>
> >> -- 
> >> Christophe
> > 
> >>  ra144enc.c |    1 +
> >>  1 file changed, 1 insertion(+)
> >> 8114bb18e0c0f33daf602a734a4b1085fb57d5ec  0001-ra144enc-fix-use-of-scalarprod_int16.patch
> >> From 7bd21a292e3cd21722708eb6af176e6f66e7ee21 Mon Sep 17 00:00:00 2001
> >> From: Christophe Gisquet <christophe.gisquet at gmail.com>
> >> Date: Wed, 5 Mar 2014 13:00:23 +0100
> >> Subject: [PATCH] ra144enc: fix use of scalarprod_int16
> >>
> >> c3390fd56cf55259ea7665ecea6c8aeddf56e2fc made use of the DSP function
> >> but did not complement it with a call to emms, which is done here before
> >> computations involving floats are performed.
> >>
> >> Fixes ticket #3429, which affected MMX/MMXExt machines.
> > 
> > applied
> > 
> > also made the emms more conditional, though iam not totally happy
> > about my solution its kind of ugly ...
> 
> This doesn't appear to have fixed the problem.
> Adding
> 
> %if mmsize == 8
>     emms
> %endif
> 
> at the end of scalarproduct_int16 in dsputil.c like it's done in other files 
> however worked for me.

can you send a patch ?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140305/c1e210fc/attachment.asc>