[FFmpeg-devel] [PATCH] ra144enc: fix use of scalarprod_int16

[Michael Niedermayer]

On Wed, Mar 05, 2014 at 09:50:35PM +0100, Christophe Gisquet wrote:
> Hi,
> 
> 2014-03-05 19:51 GMT+01:00 James Almer <jamrial at gmail.com>:
> > This doesn't appear to have fixed the problem.
> 
> I guess Michael's addition is the one not working?
> 
> > Adding
> >
> > %if mmsize == 8
> >     emms
> > %endif
> >
> > at the end of scalarproduct_int16 in dsputil.c like it's done in other files
> > however worked for me.
> 
> The issue here is that emms might be emitted quite frequently, which I
> believe was Michael's reason to do this. I have just verified he is
> right: the ssse3 version takes ~155 cycles, and adding unconditionally
> emms brings it to 185.
> 
> Anyway, this is weird. At this point, I think this is causing more
> headaches than encoding with such a codec is worth.
> 
> I'd suggest reverting the change altogether, because adding emms to
> the dsp is probably more detrimental.

no objections to that either, iam happy to apply whetever patch is
preferred


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140305/99bde770/attachment.asc>