[FFmpeg-devel] [PATCH] configure: make it possible to disable xlib dependancy

[Michael Niedermayer]

On Tue, Feb 18, 2014 at 08:51:47PM -0800, Timothy Gu wrote:
> On Tue, Feb 18, 2014 at 7:08 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > The unconditional dependancy was added in 7671dd7cd7d51bbd637cc46d8f104a141bc355ea
> >
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  configure |    9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> Just some nitpicking
> 
> >
> > diff --git a/configure b/configure
> > index 0ad174c..8518410 100755
> > --- a/configure
> > +++ b/configure
> > @@ -257,6 +257,7 @@ External library support:
> >    --enable-openssl         enable openssl [no]
> >    --enable-x11grab         enable X11 grabbing [no]
> >    --disable-zlib           disable zlib [autodetect]
> > +  --disable-xlib           disable xlib [autodetect]
> 
> x goes before z
> 
> >
> >  Advanced options (experts only):
> >    --cross-prefix=PREFIX    use PREFIX for compilation tools [$cross_prefix]
> > @@ -1398,6 +1399,7 @@ CONFIG_LIST="
> >      swscale_alpha
> >      thumb
> >      version3
> > +    xlib
> >      xmm_clobber_test
> >  "
> 
> Can you make xlib a member of EXTERNAL_LIBRARY_LIST and delete it from
> HAVE_LIST? It seems logical to group this with zlib.
> 
> >
> > @@ -2500,6 +2502,7 @@ enable swscale_alpha
> >
> >  # Enable hwaccels by default.
> >  enable dxva2 vaapi vdpau xvmc
> > +enable xlib
> >
> >  # build settings
> >  SHFLAGS='-shared -Wl,-soname,$$(@F)'
> 

changes made
applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140311/c599690f/attachment.asc>