[FFmpeg-devel] [PATCH] doc/examples/muxing: make compatible with C++

Anshul anshul.ffmpeg at gmail.com
Thu Mar 13 18:15:31 CET 2014



Michael Niedermayer <michaelni at gmx.at> wrote:
>On Thu, Mar 13, 2014 at 10:22:07PM +0530, Anshul wrote:
>[...]
>> >/* rescale output packet timestamp values from codec to stream
>timebase
>> >*/
>> >-    pkt->pts = av_rescale_q_rnd(pkt->pts, *time_base,
>st->time_base,
>> >AV_ROUND_NEAR_INF|AV_ROUND_PASS_MINMAX);
>> >-    pkt->dts = av_rescale_q_rnd(pkt->dts, *time_base,
>st->time_base,
>> >AV_ROUND_NEAR_INF|AV_ROUND_PASS_MINMAX);
>> >+    pkt->pts = av_rescale_q_rnd(pkt->pts, *time_base,
>st->time_base,
>> >(AVRounding)(AV_ROUND_NEAR_INF|AV_ROUND_PASS_MINMAX));
>> >+    pkt->dts = av_rescale_q_rnd(pkt->dts, *time_base,
>st->time_base,
>> >(AVRounding)(AV_ROUND_NEAR_INF|AV_ROUND_PASS_MINMAX));
>> >pkt->duration = av_rescale_q(pkt->duration, *time_base,
>st->time_base);
>> >     pkt->stream_index = st->index;
>> > 
>> Its an program, which is written in *.c, I dont know how this whole
>example would be use by c++ code.
>
>The user uses an example in his application, its sort of the purpose
>of the examples to be used by "users" in their applications
>
>this application may be C++ code
>
>[...]

It not a matter of debate, but if they see cpp file with those ifdef then purpose will get more highlight. Its just an opinion, this patch is good overall.

-Anshul
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.


More information about the ffmpeg-devel mailing list