[FFmpeg-devel] [PATCH] avcodec: Add padding after the remaining AVFrames

Michael Niedermayer michaelni at gmx.at
Tue Mar 18 14:59:40 CET 2014


On Tue, Mar 18, 2014 at 02:18:40PM +0100, wm4 wrote:
> On Tue, 18 Mar 2014 14:06:50 +0100
> Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > On Tue, Mar 18, 2014 at 01:25:26PM +0100, wm4 wrote:
> > > On Tue, 18 Mar 2014 00:48:41 +0100
> > > Michael Niedermayer <michaelni at gmx.at> wrote:
> > > 
> > > > This limits ABI issues in case libavcodec is linked to a libavutil with larger AVFrame
> > > > Which can happen if they are shiped in seperate binary packages and libavutil is upgraded
> > > > 
> > > > A cleaner alternative would be to replace them by pointers but this would likely cause
> > > > a small speedloss
> > > 
> > > Better idea: call abort() if the libavutil linked version doesn't match
> > > the compiled version.
> > 
> > That would badly break distro packages and is near certain to get
> > ffmpeg kicked out of distros and i actually agree that a lib
> > calling abort() when one of its dependancies has a different minor
> > version but same soname ... is just broken.
> 
> Better than silently triggering undefined behavior or other bugs.

which this patch fixes or which would be fixed by changing 3
fields from structure to pointer.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140318/c2a0f6ea/attachment.asc>


More information about the ffmpeg-devel mailing list