[FFmpeg-devel] [PATCH] Fix read past the end of ff_h264_cabac_tables

[Evgeniy Stepanov]

Ouch. You are right, there is no overread.
Please disregard the patch.

On Sun, Mar 23, 2014 at 9:23 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sun, Mar 23, 2014 at 07:02:29PM +0400, Evgeniy Stepanov wrote:
>> Hi,
>>
>> this patch fixes a benign read past the end of global ff_h264_cabac_tables[].
>> The code in decode_significance_8x8_x86 reads it 4 bytes at a time and
>> can over-read the table by 1 byte to the right. See
>> https://trac.ffmpeg.org/ticket/3490.
>>
>> Please review.
>
> the instruction the ticket points to reads 1 byte not 4 byte
> where does the overread happen exactly?
> do you have a testcase to reproduce this ?
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Concerning the gods, I have no means of knowing whether they exist or not
> or of what sort they may be, because of the obscurity of the subject, and
> the brevity of human life -- Protagoras
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>