[FFmpeg-devel] [PATCH]Never specify asm constraint twice in cavsdsp.c

Matt Oliver protogonoi at gmail.com
Sat May 3 10:22:56 CEST 2014

> > For example just change the line from:
> > QPEL_CAVSVNUM(QPEL_CAVSV2,OP,ff_pw_4,ff_pw_5,ff_pw_5)         \
> > to:
> > QPEL_CAVSVNUM(QPEL_CAVSV2,OP,ff_pw_4,ff_pw_5,ff_pw_42)        \
> Please send a patch.

OK I made up a a patch and attached it.

Or maybe "dummy"...

Unfortunately named constraints have to exist even if they are never used
as otherwise they generate a compile error. Given theres no point creating
a temp variable then may as well use an existing one. If it needs to be
explicitly stated then a comment can be added to point out that it is never
actually used but given that was never done previously then changing it to
pw_42 should suffice.

The vf_fspp.c issue should already be fixed but thank
> you for confirming I didn't miss anything.

Well attached is a patch to remove the multiply defined named constraints
anyway (just in case its useful).

Where you able to test ced0d6c1 / ticket #3472 with
> icc on Windows?

So far I havnt seen any problems with it with icl but ill run up some
proper tests and let you know.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x86-cavdsp-prevent-named-constraints-appearing-twice.patch
Type: application/octet-stream
Size: 979 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140503/3782ad20/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libmpcodecs-fix-named-constraints-being-listed-twice.patch
Type: application/octet-stream
Size: 1196 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140503/3782ad20/attachment-0001.obj>

More information about the ffmpeg-devel mailing list