[FFmpeg-devel] [PATCH 1/6] lavu: add av_gettime_relative()

[Nicolas George]

L'octidi 18 floréal, an CCXXII, LANGLOIS Olivier PIS -EXT a écrit :
> Yes. that was on purpose. While it is true that the function
> av_gettime_monotonic() from lavd does not conflict anymore since we
> renamed the function in lavu, they are still essentially identical so in
> order to avoid unnecessary code replication, I have made v4l2 use the new
> lavu function as in previous versions of the patch. One could argue that
> since the function av_gettime_relative() may not always be implemented as
> monotonic, in order to avoid a possible maintenance glitch in case that
> theoretically av_gettime_relative() on Linux would stop being identical to
> v4l2's av_gettime_monotonic(), it would be better to leave v4l2.c as is.
> 
> If that is what you have in mind, I can drop these changes. Just let me
> know if I read your comment correctly.

I think you missed my meaning. The change to v4l2 is good in itself, I was
asking why you kept it together with the change to lavu, while you split the
other changes into separate patches.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140510/2d68d9de/attachment.asc>