[FFmpeg-devel] [PATCH] EBU Tech 3285 – Supplement 3 - Peak Envelope Chunk encoder

Carl Eugen Hoyos cehoyos at ag.or.at
Sun May 11 19:27:48 CEST 2014


Georg Lippitsch <georg.lippitsch <at> gmx.at> writes:

> >> +        /* format header */
> >> +        fmt = ff_start_tag(pb, "fmt ");
> >> +        if (ff_put_wav_header(pb, s->streams[0]->codec, 0) < 0) {
> >
> > It makes reviewing the patch much easier if you don't reindent
> > these lines in the same commit: Just leave them where they
> > are now.
> 
> You mean simply not indent the whole block?

Do not re-indent the whole block, just leave all 
otherwise unchanged lines how they are to ease 
reviewing.

You may re-indent in a follow-up patch that only 
changes indentation.

Carl Eugen



More information about the ffmpeg-devel mailing list