[FFmpeg-devel] [PATCH]Refuse to mux H.264 without startcode in avi

[Michael Niedermayer]

On Fri, May 23, 2014 at 09:54:16AM +0200, Carl Eugen Hoyos wrote:
> On Friday 23 May 2014 01:56:07 am Michael Niedermayer wrote:
> > On Fri, May 23, 2014 at 12:57:47AM +0200, Carl Eugen Hoyos wrote:
> > > Hi!
> > >
> > > Current vanilla WMP does support H264 video in avi if it has startcodes
> > > and if the codec_tag is H264.
> > > Particularly the first dependency is not well documented afaict, see also
> > > ticket #3638. Attached patch refuses to mux H264 without startcode into
> > > avi, an alternative would be to just print a warning: Players != WMP seem
> > > to work fine.
> > >
> > > Please comment, Carl Eugen
> 
> > > +    if (enc->codec_id == AV_CODEC_ID_H264) {
> >
> > this check should be on the fourcc not the codec id, at least if one
> > is pedantic
> > different fourccs can and likely do have different official
> > decoder implementations, which may have different limitations
> > and some might even reject what others require
> 
> New patch attached.
> 
> Thank you, Carl Eugen

>  Makefile |    2 +-
>  avienc.c |    6 ++++++
>  2 files changed, 7 insertions(+), 1 deletion(-)
> c2c455996df54de536f6f9f193fb884bcc1b237f  patchh264avi.diff
> diff --git a/libavformat/Makefile b/libavformat/Makefile

probably ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140523/945afea9/attachment.asc>