[FFmpeg-devel] [PATCH] x86/dsputil: fix VECTOR_CLIP_INT32 macro

James Almer jamrial at gmail.com
Fri May 23 17:54:09 CEST 2014


On 23/05/14 4:31 AM, Christophe Gisquet wrote:
> Hi,
> 
> 2014-05-23 9:05 GMT+02:00 James Almer <jamrial at gmail.com>:
>> The inline loop was incrementing and using the value of %%i
>> the wrong way.
> 
> Nice catch. But wouldn't that mean the function may have output
> garbage? If yes, why wasn't fate catching this ?

Because fate-ac3-fixed-encode doesn't need any clipping (all the 
values are apparently in range), and the same pointer is used for
both src and dst.

But yes, i suppose there's a big chance many real world ac3 fixed 
encodes ended up with garbage.


More information about the ffmpeg-devel mailing list