[FFmpeg-devel] [PATCH 1/3] Add replay_gain and find_peak_sample options to libmp3lame

[Clément Bœsch]

On Fri, May 23, 2014 at 07:40:14PM -0700, Giovanni Motta wrote:
> Add Lame tag to the Xing/Info header of mp3 files.
> 
> Fixes ticket #3577
> 
> A few notes/comments:
> 
> - A failing FATE test has been updated with new CRC.
> 
> - The Lame info tag is generated by libmp3lame and passed to the mp3enc via extradata.
> 
> - To keep the size of the tag constant and simplify the code, vbr_scale is always added.
> 
> - The Lame string vendor in the tag is fixed length, so vendor is trimmed
>   to 9 bytes and padded with 0x20 if shorter.
> 
> - replay_gain and find_peak need a version of lame patched with
>   libmp3lame/lame.c Revision 1.367 (patch tracker item #66): http://sourceforge.net/p/lame/patches/66/
>   They have no effect otherwise.
> 
> - find_peak_sample only works if Lame is configured with --enable-decoder.
>   It has no effect otherwise.
> 
> - Some fields in the Lame tag are not set because not accessible from
>   the set/get API (preset and noise shaping, for example). I will bring this to
>   the attention of the Lame developers and help there with any change if we
>   decide to merge the patch.
> 
> Thanks
> 
> Giovanni
> 

Note: you copied this in the description of each patch. If applied as
such, this description will end up in every commit, which is probably not
what you/we want. What you were looking for here was probably the
--compose option of git-send-email (which create a PATCH 0/N mail with
that description) and not --annotate (specific description for each
patch).

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140524/32c7b45a/attachment.asc>