[FFmpeg-devel] [PATCH] libavformat: libavformat: output cues for each subtitle block in MKV muxer

Clément Bœsch u at pkh.me
Sun May 25 10:53:17 CEST 2014


On Thu, May 22, 2014 at 04:22:32PM -0400, John Peebles wrote:
> If you use ffmpeg to remux an mkv file and the file has ASS subtitles, only
> the first subtitle with a given timecode will be added to the list of cues.
> This is caused by two issues:
> (1) the MKV muxer only writes one cue per AVPacket, but ASS subtitles may
> have multiple blocks corresponding to one AVPacket.
> (2) The MKV muxer only writes a cue for the first block in a track with a
> given timecode. For subtitles, multiple blocks may have the same timecode.
> This patch fixes these issues by always writing one cue per block for
> subtitle tracks, even if multiple blocks have the same timecode.

This patch doesn't apply on FFmpeg git master.

Also, please do not include re-indent change into the patch (keep it
broken, we will fix it in the next commit), it's easier to review or solve

Can you also provide a sample and command line to reproduce?


Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140525/2bc38ab4/attachment.asc>

More information about the ffmpeg-devel mailing list