[FFmpeg-devel] [PATCH]Do not require pkg-config for libx265

[Hendrik Leppkes]

On Mon, May 26, 2014 at 5:40 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Stephen Hutchinson <qyot27 <at> gmail.com> writes:
>
>> Simply as confirmation, --pkg-config-flags="--static"
>> is all that's necessary.
>
> Why is it necessary if I only built a static library?
> (How does a user on a random system know that his
> admin only installed a static library?)
>
> And how am I supposed to pass this option only
> for x265? I don't want all libraries to be linked
> statically just because there is no dynamic x265
> on my system.
>
> I originally thought that this is just a choice
> between different working solutions depending on what
> is easier for users. It is funny how many bugs this
> "working" pkg-config solution has after looking at it
> for a short period of time.
>

The entire build system is not designed for "selective" static
linking, either its all or nothing.
Hacking this into x265 manually won't fix the build system, in fact,
it will make it even more terrible.

If a library exposes a pkg-config script, the way to go is to use it,
and let the developers of said library deal with C/LD flags and
library deps. This is all.