[FFmpeg-devel] [PATCH] x86/dsputilenc: implement SSE2 version of diff_pixels

James Almer jamrial at gmail.com
Mon May 26 19:46:53 CEST 2014


On 26/05/14 4:56 AM, Christophe Gisquet wrote:
> Hi,
> 
> 2014-05-26 8:49 GMT+02:00 James Almer <jamrial at gmail.com>:
>> +INIT_XMM sse2
>> +cglobal diff_pixels, 4,5
> 
> Doesn't matter as it's below 6, but properly defining the xmm reg
> count could be nice.

I was essentially copying the style used for get_pixels and pix_* so everything 
looks consistent.

> Also, maybe you could (port and) merge with the mmx version?
> 

Tried that but the ifdeffery made it look quite ugly as several instructions 
inside the loop are not shared even after using mmsize with others.

> But I really don't mind this going in as is, all the more since you
> may have your hands full with something else.
> 
> Best regards,
> 



More information about the ffmpeg-devel mailing list