[FFmpeg-devel] [PATCH]Check if free atoms in mov are actually moov atoms

[Michael Niedermayer]

On Sat, May 31, 2014 at 10:29:05AM +0200, Carl Eugen Hoyos wrote:
> On Thursday 06 March 2014 01:29:13 pm Carl Eugen Hoyos wrote:
> > Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
> > > Attached patch fixes ticket #1551, this is how vlc decodes
> > > the sample.
> >
> > As-is, this is probably not such a good idea, the vlc code
> > only uses the "bad" atom if no moov atom was found:
> > http://git.videolan.org/?p=vlc.git;a=commitdiff;h=b5a213db
> 
> New patch attached.
> 
> Please comment, Carl Eugen

>  isom.h |    1 +
>  mov.c  |   17 +++++++++++++++++
>  2 files changed, 18 insertions(+)
> 6a6133045ad254409037d8b423fba00507af6f74  patchmoovfree2.diff
> diff --git a/libavformat/isom.h b/libavformat/isom.h
> index a5934af..253451e 100644

LGTM

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140531/051a8ca5/attachment.asc>