[FFmpeg-devel] [PATCH 2/2] [RFC]lavf/ffm: update with more options.

[Michael Niedermayer]

On Mon, Nov 03, 2014 at 01:05:53PM +0100, Lukasz Marek wrote:
> On 3 November 2014 01:31, Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > On Sun, Nov 02, 2014 at 07:19:14PM +0100, Lukasz Marek wrote:
> >
> >
> > shouldnt all these values be checked to be within the allowed ranges
> > for the corresponding AVOptions?
> >
> > being able to set so many field so arbitrarily could be usefull to
> > some kind of exploit ...
> >
> 
> Yes, it wouldn't hurt to set them via AVOption API which implies validation.
> OTOH most options doesn't set any reasonable range, just INT_MIN - INT_MAX
> 

> Remarkable example:
> {"ac", "set number of audio channels", OFFSET(channels), AV_OPT_TYPE_INT,
> {.i64 = DEFAULT }, INT_MIN, INT_MAX, A|D|E},

fixed the negative side of the range

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141103/bec98b22/attachment.asc>