[FFmpeg-devel] [PATCH] x86/swr: add ff_float_to_int32_a_avx2

Christophe Gisquet christophe.gisquet at gmail.com
Fri Nov 7 10:05:25 CET 2014


2014-11-06 23:04 GMT+01:00 James Almer <jamrial at gmail.com>:
> No, the function checks for alignment and jumps to a branch that uses movdqu if needed.
> ff_int32_to_float_a_avx also uses ymm regs and this same macro.

OK, so nothing new here, same 32-bytes alignment.

> when "mulps m0, m1, [mem]" would work just as well regardless of alignment.

It does with AVX? That shows I never used it...

> If you use "cmpps m0, m1, 5" it will work for non-VEX coding, but error out otherwise
> since x86inc.asm turns that into "vcmpps m0, m1, 5" instead of "vcmpps m0, m0, m1, 5"
> With aliases like cmpnltps it doesn't even add the "v" prefix.

OK. As you are the number one developer for AVX, it's up to you
whether that would need a more generic fix :-)

Someone actually used to AVX should comment, but this patch looks so
simple that you should apply it tomorrow if nobody objects.

Best regards,

More information about the ffmpeg-devel mailing list