[FFmpeg-devel] [PATCH]Clarify that the tcp timeout option takes microseconds

Stefano Sabatini stefasab at gmail.com
Wed Nov 12 13:26:26 CET 2014


On date Wednesday 2014-11-12 10:56:08 +0100, Carl Eugen Hoyos encoded:
> Hi!
> 
> Attached patch improves the option documentation imo.
> 
> Please comment, Carl Eugen

> diff --git a/libavformat/tcp.c b/libavformat/tcp.c
> index a1b1856..0aabc9d 100644
> --- a/libavformat/tcp.c
> +++ b/libavformat/tcp.c
> @@ -45,7 +45,7 @@ typedef struct TCPContext {
>  #define E AV_OPT_FLAG_ENCODING_PARAM
>  static const AVOption options[] = {
>      { "listen",          "Listen for incoming connections",  OFFSET(listen),         AV_OPT_TYPE_INT, { .i64 = 0 },     0,       1,       .flags = D|E },
> -    { "timeout",     "set timeout of socket I/O operations", OFFSET(rw_timeout),     AV_OPT_TYPE_INT, { .i64 = -1 },         -1, INT_MAX, .flags = D|E },
> +    { "timeout",     "set timeout (in microseconds) of socket I/O operations", OFFSET(rw_timeout),     AV_OPT_TYPE_INT, { .i64 = -1 },         -1, INT_MAX, .flags = D|E },
>      { "listen_timeout",  "set Connection awaiting timeout",      OFFSET(listen_timeout), AV_OPT_TYPE_INT, { .i64 = -1 },         -1, INT_MAX, .flags = D|E },
>      { NULL }
>  };

LGTM.
-- 
FFmpeg = Furious Fanciful Mortal Portentous Enhanced God


More information about the ffmpeg-devel mailing list