[FFmpeg-devel] [PATCH 2/2] avcodec/nellymoser: Use avpriv_float_dsp_alloc()

Reimar Döffinger Reimar.Doeffinger at gmx.de
Fri Nov 14 20:45:43 CET 2014


On Fri, Nov 14, 2014 at 08:38:39PM +0100, Michael Niedermayer wrote:
> On Fri, Nov 14, 2014 at 07:59:17PM +0100, Reimar Döffinger wrote:
> > On Fri, Nov 14, 2014 at 02:39:46PM +0100, Michael Niedermayer wrote:
> > > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > > ---
> > >  libavcodec/nellymoserdec.c |    9 ++++++---
> > >  libavcodec/nellymoserenc.c |   17 +++++++++++------
> > >  2 files changed, 17 insertions(+), 9 deletions(-)
> > > 
> > > diff --git a/libavcodec/nellymoserdec.c b/libavcodec/nellymoserdec.c
> > > index ef16fd6..2d8a594 100644
> > > --- a/libavcodec/nellymoserdec.c
> > > +++ b/libavcodec/nellymoserdec.c
> > > @@ -51,7 +51,7 @@ typedef struct NellyMoserDecodeContext {
> > >      AVLFG           random_state;
> > >      GetBitContext   gb;
> > >      float           scale_bias;
> > > -    AVFloatDSPContext fdsp;
> > > +    AVFloatDSPContext *fdsp;
> > 
> > Why, and why only for Nellymoser?
> > I could see it from an ABI compatibility standpoint, but wouldn't
> > this be fairly pointless unless all other uses are changed as well?
> 
> it will be done for all uses after the API itself is pushed.
> nelly was just an example and for ensuring the API is tested & works

Ok, but I think then it would be good to mark avpriv_float_dsp_init
as deprecated and for removal on next major bump, to both make the
purpose of the patch more clearer and avoid adding more incorrect
usages by accident later.


More information about the ffmpeg-devel mailing list