[FFmpeg-devel] [PATCH 05/11] ffserver: allow skip setting defaults

Reynaldo H. Verdejo Pinochet reynaldo at osg.samsung.com
Tue Nov 18 21:54:46 CET 2014


On 11/16/2014 10:46 PM, Lukasz Marek wrote:
> diff --git a/doc/ffserver.texi b/doc/ffserver.texi
> index b7c5b6a..d3ff13e 100644
> --- a/doc/ffserver.texi
> +++ b/doc/ffserver.texi
> @@ -408,6 +408,11 @@ ignored, and the log is written to standard output.
>  Set no-daemon mode. This option is currently ignored since now
>  @command{ffserver} will always work in no-daemon mode, and is
>  deprecated.
> +
> + at item UseDefaults
> + at item NoDefaults
> +Control whether default codec options are used for the all streams or not.
> +Each stream may overwrite this setting for its own. Default is @var{UseDefaults}.
> [...]

I think I commented about this before but having yesvar & novar
options seems redundant. Having var = yes or no if absent (or the
other way around depending on the intended default) seems less
cumbersome and should simplify the code a bit too, avoiding checking
for the two and imposing a precedence, which is not always
documented. What do you think? This happens twice on this patch

Otherwise seems OK to push.


Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley

More information about the ffmpeg-devel mailing list