[FFmpeg-devel] [PATCH] ffplay: fix mem leak when opening input or parsing options fail.

[Michael Niedermayer]

On Thu, Nov 20, 2014 at 04:01:27PM +0100, Benoit Fouet wrote:
> ---
>  ffplay.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ffplay.c b/ffplay.c
> index f79161d..3009c82 100644
> --- a/ffplay.c
> +++ b/ffplay.c
> @@ -3169,8 +3169,8 @@ static int read_thread(void *arg)
>          stream_component_close(is, is->video_stream);
>      if (is->subtitle_stream >= 0)
>          stream_component_close(is, is->subtitle_stream);
> -    if (is->ic) {
> -        avformat_close_input(&is->ic);
> +    if (ic) {
> +        avformat_close_input(&ic);

is->ic should be set to NULL i think
avformat_close_input did that previously

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

You can kill me, but you cannot change the truth.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141120/1530af7c/attachment.asc>