[FFmpeg-devel] [PATCH] configure: Prevent icl being incorrectly detected as msvc.

Matt Oliver protogonoi at gmail.com
Thu Nov 20 20:03:36 CET 2014


On 21 November 2014 02:28, Matt Oliver <protogonoi at gmail.com> wrote:

> On 21 November 2014 01:23, Derek Buitenhuis <derek.buitenhuis at gmail.com>
> wrote:
>
>> On 11/20/2014 8:40 AM, Benoit Fouet wrote:
>> > LGTM
>>
>>
>> http://fate.ffmpeg.org/report.cgi?time=20141120142015&slot=i686-windows-icl
>>
>> - Derek
>>
>
> Works fine with lto, but apparently one shouldnt assume the existing code
> is correct for the other cases :P. It appears there was actually an error
> in configure thats been there all along that was never found as it was
> incorrectly detecting icl linker as msvc. Anyway its just missing a couple
> of values that are set for msvc but werent for icl. Im testing a patch now
> so should have fixed it soon.
>
>
OK, all it needed was to disable stripping with icl. Its one of those
things where it took 2 mins to write a patch but then several hours to test
it ;). This has apparently been missing for several years but only became
evident now. So the attached patch should fix everything up.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-configure-disable-strip-when-using-icl.patch
Type: application/octet-stream
Size: 646 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141121/af4de720/attachment.obj>


More information about the ffmpeg-devel mailing list