[FFmpeg-devel] [PATCH 06/11] [WIP][RFC]tools: add ffserver_config_test

[Lukasz Marek]

On 21.11.2014 00:14, Alexander Strasser wrote:
> Hi Lukasz!
>
> On 2014-11-19 00:06 +0100, Lukasz Marek wrote:
>> On 18.11.2014 22:20, Reynaldo H. Verdejo Pinochet wrote:
>>> Hi. Overall this looks good, thanks. I would move the test to
>>> tests/ though and integrate it with the build/test system as,
>>> say, the way tiny_ssim is:
>>>
>>> grep -R tiny_ssim *
>>> Makefile:TESTTOOLS   = audiogen videogen rotozoom tiny_psnr tiny_ssim base64
>>> tests/Makefile:FATE_UTILS = base64 tiny_psnr tiny_ssim
>>> tests/tiny_ssim.c: * tiny_ssim.c
>>> tests/tiny_ssim.c:        printf("tiny_ssim <file1.yuv> <file2.yuv>
>>> <width>x<height> [<seek>]\n");
>>
>> I tried as I remember but this test need to be linked with ffmpeg's libs
>> so adding it to FATE_UTILS is not enough
>
>    Would it help with the build of ffserver_config_test if you apply
> this (based on your github ffserver branch):
>
> --- a/Makefile
> +++ b/Makefile
> @@ -69,8 +69,8 @@ $(TOOLS): %$(EXESUF): %.o $(EXEOBJS)
>   tools/cws2fws$(EXESUF): ELIBS = $(ZLIB)
>   tools/uncoded_frame$(EXESUF): $(FF_DEP_LIBS)
>   tools/uncoded_frame$(EXESUF): ELIBS = $(FF_EXTRALIBS)
> -tools/ffserver_config_test$(EXESUF): $(FF_DEP_LIBS)
> -tools/ffserver_config_test$(EXESUF): ELIBS = ffserver_config.o cmdutils.o $(FF_DEP_LIBS) -lm
> +tools/ffserver_config_test$(EXESUF): ffserver_config.o cmdutils.o $(FF_DEP_LIBS)
> +tools/ffserver_config_test$(EXESUF): ELIBS = $(FF_EXTRALIBS)
>
>   config.h: .config
>   .config: $(wildcard $(FFLIBS:%=$(SRC_PATH)/lib%/all*.c))

Looks like it is working, thanks!

>
>    Regarding the code in ffserver_config_test.c, it look still quite raw
> from a very quick look. IIUC it writes data to a hardcoded path in /tmp
> so at least relocating that relative to the binary location itself or
> something like that should be better I think.

Yes, it is raw. I posted it because I needed help with Makefile and as 
reference (I changed quite much that code so I needed to do some 
regression test).